Skip to content

feat: Support multi-configuration OID4VCI issuance - #469

Merged
smncd merged 4 commits into
release/sirosidfrom
feat/multi-credential-issuance
Nov 18, 2026
Merged

smncd merged 4 commits into
release/sirosidfrom
feat/multi-credential-issuance

Conversation

@smncd

@smncd smncd commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

Support scenarios where during issuance, multiple credentials are issued in the same flow.
We need to handle each of these, since they could have different encryption configurations,
and validate and group them before storage.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Performance
  • Documentation
  • Tests
  • Build/CI
  • Chore

Related issues / tickets

Changes

  • keep decrypted responses per credential configuration
  • match completed flows per configuration
  • answer user_selects with everything for now

Checklist

  • I self-reviewed my changes
  • I added/updated tests (or explained why not)
  • I updated documentation (if needed)
  • I ran the relevant checks locally (lint/unit/integration)
  • I verified backward compatibility / migration notes (if needed)
  • I added monitoring/logging (if needed)

Security checklist

  • No secrets, credentials, or API keys are hardcoded
  • New dependencies have been reviewed for known vulnerabilities
  • User input is validated and sanitized where applicable
  • No new attack surface introduced without security review
  • PII/sensitive data handling follows data protection policies
  • N/A — this PR does not affect code, deps, or configuration

Notes for reviewers

  • ...

- keep decrypted responses per credential configuration
- match completed flows per configuration
- answer `user_selects` with everything for now
@smncd
smncd requested a review from a team as a code owner November 18, 2026 11:23
@changeset-bot

changeset-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e418449

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wallet-frontend Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smncd
smncd requested a review from leifj November 18, 2026 11:26
@smncd smncd self-assigned this Nov 18, 2026
@smncd
smncd requested a balanced review from Copilot November 18, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A pending decryption can restore credentials and secret metadata after cancellation, disconnect, or key regeneration because the result is stored without verifying that the flow still owns the same key entry.

1 open issue
What changed in this PR

Adds multi-configuration OID4VCI issuance support, allowing the wallet to handle credentials with different encryption settings within one flow.

Changes:

  • Tracks decrypted responses, metadata, notifications, and failures per configuration.
  • Automatically selects all offered configurations for user_selects flows.
  • Prepares and validates separate storage batches per configuration, with expanded regression tests.
File Description
src/​lib/​openid-flow/​utils/​credentialNotifications.ts Uses the renamed notificationId field.
src/​lib/​openid-flow/​types/​OID4VCITypes.ts Adds per-credential configuration and metadata fields, plus configuration failures.
src/​lib/​openid-flow/​transports/​OIDFlowWebSocketTransport.ts Matches completion results per configuration and handles automatic selection.
src/​lib/​openid-flow/​encryption/​ClientHeldEncryptionKeys.ts Retains decrypted responses and encryption-offer state per configuration.
src/​lib/​openid-flow/​encryption/​ClientHeldEncryptionKeys.test.ts Tests configuration isolation, key replacement, and response retention.
src/​lib/​openid-flow/​__tests__/​OIDFlowWebSocketTransport.test.ts Covers multi-configuration completion, partial failures, and selection.
src/​lib/​openid-flow/​__tests__/​OIDFlowNotification.test.ts Updates notification tests for notificationId.
src/​hooks/​useOID4VCIFlow.ts Groups credentials into configuration-specific batches before storage.
.changeset/​bumpy-ghosts-wonder.md Records the feature as a minor release change.

Review effort: Balanced

@smncd
smncd requested a review from s-jairl November 18, 2026 15:50
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
79.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@s-jairl s-jairl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good AFAICT!

@smncd
smncd merged commit f2debf7 into release/sirosid Nov 18, 2026
13 of 14 checks passed
@smncd
smncd deleted the feat/multi-credential-issuance branch November 18, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OID4VCI: issue every credential in a multi-credential offer

3 participants